summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorChristophe Leroy <christophe.leroy@c-s.fr>2016-08-03 12:41:40 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2016-08-08 11:58:43 +0200
commit0d35d0815b19216f852f257afe420f7c7d182780 (patch)
tree99bffa0fa77acfd0a8215617897350a233f7f3a8 /net
parentc1eda3c6394f805886b2afa8c7ea5e04305ec698 (diff)
downloadlinux-stable-0d35d0815b19216f852f257afe420f7c7d182780.tar.gz
linux-stable-0d35d0815b19216f852f257afe420f7c7d182780.tar.bz2
linux-stable-0d35d0815b19216f852f257afe420f7c7d182780.zip
netfilter: nf_conntrack_sip: CSeq 0 is a valid CSeq
Do not drop packet when CSeq is 0 as 0 is also a valid value for CSeq. simple_strtoul() will return 0 either when all digits are 0 or if there are no digits at all. Therefore when simple_strtoul() returns 0 we check if first character is digit 0 or not. Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/nf_conntrack_sip.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c
index 8d9db9d4702b..7d77217de6a3 100644
--- a/net/netfilter/nf_conntrack_sip.c
+++ b/net/netfilter/nf_conntrack_sip.c
@@ -1383,7 +1383,7 @@ static int process_sip_response(struct sk_buff *skb, unsigned int protoff,
return NF_DROP;
}
cseq = simple_strtoul(*dptr + matchoff, NULL, 10);
- if (!cseq) {
+ if (!cseq && *(*dptr + matchoff) != '0') {
nf_ct_helper_log(skb, ct, "cannot get cseq");
return NF_DROP;
}
@@ -1446,7 +1446,7 @@ static int process_sip_request(struct sk_buff *skb, unsigned int protoff,
return NF_DROP;
}
cseq = simple_strtoul(*dptr + matchoff, NULL, 10);
- if (!cseq) {
+ if (!cseq && *(*dptr + matchoff) != '0') {
nf_ct_helper_log(skb, ct, "cannot get cseq");
return NF_DROP;
}