diff options
| author | David Morley <morleyd@google.com> | 2023-01-19 19:00:28 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-01-20 13:23:35 +0000 |
| commit | 300b655db1b5152d6101bcb6801d50899b20c2d6 (patch) | |
| tree | 7c17196f1a66e519a08c1fa6dec4f34af03b7591 /net | |
| parent | d3e599c090fc6977331150c5f0a69ab8ce87da21 (diff) | |
| download | linux-stable-300b655db1b5152d6101bcb6801d50899b20c2d6.tar.gz linux-stable-300b655db1b5152d6101bcb6801d50899b20c2d6.tar.bz2 linux-stable-300b655db1b5152d6101bcb6801d50899b20c2d6.zip | |
tcp: fix rate_app_limited to default to 1
The initial default value of 0 for tp->rate_app_limited was incorrect,
since a flow is indeed application-limited until it first sends
data. Fixing the default to be 1 is generally correct but also
specifically will help user-space applications avoid using the initial
tcpi_delivery_rate value of 0 that persists until the connection has
some non-zero bandwidth sample.
Fixes: eb8329e0a04d ("tcp: export data delivery rate")
Suggested-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David Morley <morleyd@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Tested-by: David Morley <morleyd@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index c567d5e8053e..33f559f491c8 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -435,6 +435,7 @@ void tcp_init_sock(struct sock *sk) /* There's a bubble in the pipe until at least the first ACK. */ tp->app_limited = ~0U; + tp->rate_app_limited = 1; /* See draft-stevens-tcpca-spec-01 for discussion of the * initialization of these values. @@ -3178,6 +3179,7 @@ int tcp_disconnect(struct sock *sk, int flags) tp->plb_rehash = 0; /* There's a bubble in the pipe until at least the first ACK. */ tp->app_limited = ~0U; + tp->rate_app_limited = 1; tp->rack.mstamp = 0; tp->rack.advanced = 0; tp->rack.reo_wnd_steps = 1; |