diff options
author | Ido Schimmel <idosch@mellanox.com> | 2020-07-29 12:26:44 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-07-29 12:16:21 -0700 |
commit | ec4f5b3617049d474b3263792785b638640f2dbe (patch) | |
tree | df64c3e2bc3c3b6bec5b87b6b70f935b95e021b1 /net | |
parent | 89ab53313543b18640eb5d25a1e74bf9eee889b0 (diff) | |
download | linux-stable-ec4f5b3617049d474b3263792785b638640f2dbe.tar.gz linux-stable-ec4f5b3617049d474b3263792785b638640f2dbe.tar.bz2 linux-stable-ec4f5b3617049d474b3263792785b638640f2dbe.zip |
mlxsw: spectrum: Use different trap group for externally routed packets
Cited commit mistakenly removed the trap group for externally routed
packets (e.g., via the management interface) and grouped locally routed
and externally routed packet traps under the same group, thereby
subjecting them to the same policer.
This can result in problems, for example, when FRR is restarted and
suddenly all transient traffic is trapped to the CPU because of a
default route through the management interface. Locally routed packets
required to re-establish a BGP connection will never reach the CPU and
the routing tables will not be re-populated.
Fix this by using a different trap group for externally routed packets.
Fixes: 8110668ecd9a ("mlxsw: spectrum_trap: Register layer 3 control traps")
Reported-by: Alex Veber <alexve@mellanox.com>
Tested-by: Alex Veber <alexve@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/devlink.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index 2cafbc808b09..dc2b18475956 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -8567,6 +8567,7 @@ static const struct devlink_trap_group devlink_trap_group_generic[] = { DEVLINK_TRAP_GROUP(PIM), DEVLINK_TRAP_GROUP(UC_LB), DEVLINK_TRAP_GROUP(LOCAL_DELIVERY), + DEVLINK_TRAP_GROUP(EXTERNAL_DELIVERY), DEVLINK_TRAP_GROUP(IPV6), DEVLINK_TRAP_GROUP(PTP_EVENT), DEVLINK_TRAP_GROUP(PTP_GENERAL), |