diff options
author | Valentin Longchamp <valentin@longchamp.me> | 2020-05-20 17:53:50 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-05-22 15:50:34 -0700 |
commit | 79dde73cf9bcf1dd317a2667f78b758e9fe139ed (patch) | |
tree | 293dd8aac7ff1ad1d16cb314825389e0ebd8acda /samples/trace_events | |
parent | d3e8e4c11870413789f029a71e72ae6e971fe678 (diff) | |
download | linux-stable-79dde73cf9bcf1dd317a2667f78b758e9fe139ed.tar.gz linux-stable-79dde73cf9bcf1dd317a2667f78b758e9fe139ed.tar.bz2 linux-stable-79dde73cf9bcf1dd317a2667f78b758e9fe139ed.zip |
net/ethernet/freescale: rework quiesce/activate for ucc_geth
ugeth_quiesce/activate are used to halt the controller when there is a
link change that requires to reconfigure the mac.
The previous implementation called netif_device_detach(). This however
causes the initial activation of the netdevice to fail precisely because
it's detached. For details, see [1].
A possible workaround was the revert of commit
net: linkwatch: add check for netdevice being present to linkwatch_do_dev
However, the check introduced in the above commit is correct and shall be
kept.
The netif_device_detach() is thus replaced with
netif_tx_stop_all_queues() that prevents any tranmission. This allows to
perform mac config change required by the link change, without detaching
the corresponding netdevice and thus not preventing its initial
activation.
[1] https://lists.openwall.net/netdev/2020/01/08/201
Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
Acked-by: Matteo Ghidoni <matteo.ghidoni@ch.abb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples/trace_events')
0 files changed, 0 insertions, 0 deletions