diff options
author | Xin Long <lucien.xin@gmail.com> | 2020-08-21 14:59:38 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-08-24 15:50:17 -0700 |
commit | 3106ecb43a05dc3e009779764b9da245a5d082de (patch) | |
tree | 885c9dba95638957cf4d2384a0489cab677710e5 /scripts/config | |
parent | 1838d6c62f57836639bd3d83e7855e0ee4f6defc (diff) | |
download | linux-stable-3106ecb43a05dc3e009779764b9da245a5d082de.tar.gz linux-stable-3106ecb43a05dc3e009779764b9da245a5d082de.tar.bz2 linux-stable-3106ecb43a05dc3e009779764b9da245a5d082de.zip |
sctp: not disable bh in the whole sctp_get_port_local()
With disabling bh in the whole sctp_get_port_local(), when
snum == 0 and too many ports have been used, the do-while
loop will take the cpu for a long time and cause cpu stuck:
[ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s!
[ ] RIP: 0010:native_queued_spin_lock_slowpath+0x4de/0x940
[ ] Call Trace:
[ ] _raw_spin_lock+0xc1/0xd0
[ ] sctp_get_port_local+0x527/0x650 [sctp]
[ ] sctp_do_bind+0x208/0x5e0 [sctp]
[ ] sctp_autobind+0x165/0x1e0 [sctp]
[ ] sctp_connect_new_asoc+0x355/0x480 [sctp]
[ ] __sctp_connect+0x360/0xb10 [sctp]
There's no need to disable bh in the whole function of
sctp_get_port_local. So fix this cpu stuck by removing
local_bh_disable() called at the beginning, and using
spin_lock_bh() instead.
The same thing was actually done for inet_csk_get_port() in
Commit ea8add2b1903 ("tcp/dccp: better use of ephemeral
ports in bind()").
Thanks to Marcelo for pointing the buggy code out.
v1->v2:
- use cond_resched() to yield cpu to other tasks if needed,
as Eric noticed.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Ying Xu <yinxu@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'scripts/config')
0 files changed, 0 insertions, 0 deletions