diff options
| author | Dmitry Bogdanov <d.bogdanov@yadro.com> | 2024-12-24 13:17:57 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2025-04-11 22:13:00 -0400 |
| commit | 7f533cc5ee4c4436cee51dc58e81dfd9c3384418 (patch) | |
| tree | cd5ca58a9360c6074d6a19e0c2ead02dd6d96e9f /scripts/extract-fwblobs | |
| parent | 3b5091fee49ffcee512901318ca2425bb1e31a5c (diff) | |
| download | linux-stable-7f533cc5ee4c4436cee51dc58e81dfd9c3384418.tar.gz linux-stable-7f533cc5ee4c4436cee51dc58e81dfd9c3384418.tar.bz2 linux-stable-7f533cc5ee4c4436cee51dc58e81dfd9c3384418.zip | |
scsi: target: iscsi: Fix timeout on deleted connection
NOPIN response timer may expire on a deleted connection and crash with
such logs:
Did not receive response to NOPIN on CID: 0, failing connection for I_T Nexus (null),i,0x00023d000125,iqn.2017-01.com.iscsi.target,t,0x3d
BUG: Kernel NULL pointer dereference on read at 0x00000000
NIP strlcpy+0x8/0xb0
LR iscsit_fill_cxn_timeout_err_stats+0x5c/0xc0 [iscsi_target_mod]
Call Trace:
iscsit_handle_nopin_response_timeout+0xfc/0x120 [iscsi_target_mod]
call_timer_fn+0x58/0x1f0
run_timer_softirq+0x740/0x860
__do_softirq+0x16c/0x420
irq_exit+0x188/0x1c0
timer_interrupt+0x184/0x410
That is because nopin response timer may be re-started on nopin timer
expiration.
Stop nopin timer before stopping the nopin response timer to be sure
that no one of them will be re-started.
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Link: https://lore.kernel.org/r/20241224101757.32300-1-d.bogdanov@yadro.com
Reviewed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'scripts/extract-fwblobs')
0 files changed, 0 insertions, 0 deletions