summaryrefslogtreecommitdiffstats
path: root/scripts/macro_checker.py
diff options
context:
space:
mode:
authorBrett Creeley <brett.creeley@amd.com>2025-04-21 10:46:04 -0700
committerJakub Kicinski <kuba@kernel.org>2025-04-23 18:50:17 -0700
commit2567daad69cd1107fc0ec29b1615f110d7cf7385 (patch)
tree32bae68f7195ce418e9f1fafda39667e1a69f20d /scripts/macro_checker.py
parentd9e2f070d8af60f2c8c02b2ddf0a9e90b4e9220c (diff)
downloadlinux-stable-2567daad69cd1107fc0ec29b1615f110d7cf7385.tar.gz
linux-stable-2567daad69cd1107fc0ec29b1615f110d7cf7385.tar.bz2
linux-stable-2567daad69cd1107fc0ec29b1615f110d7cf7385.zip
pds_core: handle unsupported PDS_CORE_CMD_FW_CONTROL result
If the FW doesn't support the PDS_CORE_CMD_FW_CONTROL command the driver might at the least print garbage and at the worst crash when the user runs the "devlink dev info" devlink command. This happens because the stack variable fw_list is not 0 initialized which results in fw_list.num_fw_slots being a garbage value from the stack. Then the driver tries to access fw_list.fw_names[i] with i >= ARRAY_SIZE and runs off the end of the array. Fix this by initializing the fw_list and by not failing completely if the devcmd fails because other useful information is printed via devlink dev info even if the devcmd fails. Fixes: 45d76f492938 ("pds_core: set up device and adminq") Signed-off-by: Brett Creeley <brett.creeley@amd.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Link: https://patch.msgid.link/20250421174606.3892-3-shannon.nelson@amd.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'scripts/macro_checker.py')
0 files changed, 0 insertions, 0 deletions