diff options
author | Takashi Iwai <tiwai@suse.de> | 2023-07-06 17:53:57 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2023-07-06 18:01:59 +0200 |
commit | 89dbb335cb6a627a4067bc42caa09c8bc3326d40 (patch) | |
tree | 8bf187a9bc1cb9ca2287b3ebafe93c234e57ba6e /sound/pci | |
parent | 5284876d82da4453df0e21f1d243b026281a6558 (diff) | |
download | linux-stable-89dbb335cb6a627a4067bc42caa09c8bc3326d40.tar.gz linux-stable-89dbb335cb6a627a4067bc42caa09c8bc3326d40.tar.bz2 linux-stable-89dbb335cb6a627a4067bc42caa09c8bc3326d40.zip |
ALSA: jack: Fix mutex call in snd_jack_report()
snd_jack_report() is supposed to be callable from an IRQ context, too,
and it's indeed used in that way from virtsnd driver. The fix for
input_dev race in commit 1b6a6fc5280e ("ALSA: jack: Access input_dev
under mutex"), however, introduced a mutex lock in snd_jack_report(),
and this resulted in a potential sleep-in-atomic.
For addressing that problem, this patch changes the relevant code to
use the object get/put and removes the mutex usage. That is,
snd_jack_report(), it takes input_get_device() and leaves with
input_put_device() for assuring the input_dev being assigned.
Although the whole mutex could be reduced, we keep it because it can
be still a protection for potential races between creation and
deletion.
Fixes: 1b6a6fc5280e ("ALSA: jack: Access input_dev under mutex")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/cf95f7fe-a748-4990-8378-000491b40329@moroto.mountain
Tested-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230706155357.3470-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
0 files changed, 0 insertions, 0 deletions