summaryrefslogtreecommitdiffstats
path: root/sound/ppc
diff options
context:
space:
mode:
authorAnders Roxell <anders.roxell@linaro.org>2021-12-07 12:00:53 +0100
committerTakashi Iwai <tiwai@suse.de>2021-12-07 15:36:56 +0100
commita98478f825862ddc1686a3335f9f1cc278fc5733 (patch)
treed507c8d74f9008a66bc90c1fd62c340d5c8324ae /sound/ppc
parentc7d58971dbea0888b6328ed0ea61089a6d62253a (diff)
downloadlinux-stable-a98478f825862ddc1686a3335f9f1cc278fc5733.tar.gz
linux-stable-a98478f825862ddc1686a3335f9f1cc278fc5733.tar.bz2
linux-stable-a98478f825862ddc1686a3335f9f1cc278fc5733.zip
ALSA: ppc: beep: fix clang -Wimplicit-fallthrough
Clang warns: sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case SND_TONE: break; ^ sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through case SND_TONE: break; ^ break; 1 warning generated. Clang is more pedantic than GCC, which does not warn when failing through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst. Add athe missing break to silence the warning. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Link: https://lore.kernel.org/r/20211207110053.695712-1-anders.roxell@linaro.org Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/ppc')
-rw-r--r--sound/ppc/beep.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/ppc/beep.c b/sound/ppc/beep.c
index 0f4bce1c0d4f..bf289783eafd 100644
--- a/sound/ppc/beep.c
+++ b/sound/ppc/beep.c
@@ -99,7 +99,7 @@ static int snd_pmac_beep_event(struct input_dev *dev, unsigned int type,
return -1;
switch (code) {
- case SND_BELL: if (hz) hz = 1000;
+ case SND_BELL: if (hz) hz = 1000; break;
case SND_TONE: break;
default: return -1;
}