summaryrefslogtreecommitdiffstats
path: root/sound/soc/intel/atom/sst-atom-controls.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2018-11-03 22:21:22 +0100
committerMark Brown <broonie@kernel.org>2018-11-05 10:38:19 +0000
commit1539c7f23f256120f89f8b9ec53160790bce9ed2 (patch)
tree0d7a4def0312deee132e230a5401af0cfcdf97b4 /sound/soc/intel/atom/sst-atom-controls.c
parent576ce4075bfa0f03e0e91a89eecc539b3b828b08 (diff)
downloadlinux-stable-1539c7f23f256120f89f8b9ec53160790bce9ed2.tar.gz
linux-stable-1539c7f23f256120f89f8b9ec53160790bce9ed2.tar.bz2
linux-stable-1539c7f23f256120f89f8b9ec53160790bce9ed2.zip
ASoC: Intel: mrfld: fix uninitialized variable access
Randconfig testing revealed a very old bug, with gcc-8: sound/soc/intel/atom/sst/sst_loader.c: In function 'sst_load_fw': sound/soc/intel/atom/sst/sst_loader.c:357:5: error: 'fw' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (fw == NULL) { ^ sound/soc/intel/atom/sst/sst_loader.c:354:25: note: 'fw' was declared here const struct firmware *fw; We must check the return code of request_firmware() before we look at the pointer result that may be uninitialized when the function fails. Fixes: 9012c9544eea ("ASoC: Intel: mrfld - Add DSP load and management") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/atom/sst-atom-controls.c')
0 files changed, 0 insertions, 0 deletions