summaryrefslogtreecommitdiffstats
path: root/sound/soc/intel/avs
diff options
context:
space:
mode:
authorCezary Rojewski <cezary.rojewski@intel.com>2024-04-05 11:09:23 +0200
committerMark Brown <broonie@kernel.org>2024-04-05 13:13:07 +0100
commitc7e832cabe635df47c2bf6df7801e97bf3045b1e (patch)
treed202212f8fb564b8ded0d1d96490be2724d3897c /sound/soc/intel/avs
parent47714847592b574ff594ceca7ebe0ada70dbac3c (diff)
downloadlinux-stable-c7e832cabe635df47c2bf6df7801e97bf3045b1e.tar.gz
linux-stable-c7e832cabe635df47c2bf6df7801e97bf3045b1e.tar.bz2
linux-stable-c7e832cabe635df47c2bf6df7801e97bf3045b1e.zip
ASoC: Intel: avs: Fix potential integer overflow
While stream_tag for CLDMA on SKL-based platforms is always 1, function hda_cldma_setup() uses AZX_SD_CTL_STRM() macro which does: stream_tag << 20 what combined with stream_tag type of 'unsigned int' generates a potential overflow issue. Update the field type to fix that. Fixes: 45864e49a05a ("ASoC: Intel: avs: Implement CLDMA transfer") Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Link: https://msgid.link/r/20240405090929.1184068-8-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/avs')
-rw-r--r--sound/soc/intel/avs/cldma.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/avs/cldma.c b/sound/soc/intel/avs/cldma.c
index d7a9390b5e48..585579840b64 100644
--- a/sound/soc/intel/avs/cldma.c
+++ b/sound/soc/intel/avs/cldma.c
@@ -35,7 +35,7 @@ struct hda_cldma {
unsigned int buffer_size;
unsigned int num_periods;
- unsigned int stream_tag;
+ unsigned char stream_tag;
void __iomem *sd_addr;
struct snd_dma_buffer dmab_data;