diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2022-08-23 15:42:19 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-08-23 19:52:38 +0100 |
| commit | a337c2012774d588fcab318c42edc2601d90e549 (patch) | |
| tree | 72cb2605974f48295356567922e3e6f6c39b9fd9 /sound/soc/sof/ipc4-loader.c | |
| parent | 1332d2078a839b371b3d541c3653a800d12a763d (diff) | |
| download | linux-stable-a337c2012774d588fcab318c42edc2601d90e549.tar.gz linux-stable-a337c2012774d588fcab318c42edc2601d90e549.tar.bz2 linux-stable-a337c2012774d588fcab318c42edc2601d90e549.zip | |
ASoC: SOF: ipc4-loader: Verify ext manifest magic number
Firmware image must start with an extended manifest. Add a check to make
sure that the image does contain it.
The magic number (the first u32 of a firmware image if manifest is present)
for an IPC4 image must be 0x31454124 (ASCI "$AE1").
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220823124219.927-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/ipc4-loader.c')
| -rw-r--r-- | sound/soc/sof/ipc4-loader.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/sound/soc/sof/ipc4-loader.c b/sound/soc/sof/ipc4-loader.c index 9fadae8fd011..8bd2132b4f41 100644 --- a/sound/soc/sof/ipc4-loader.c +++ b/sound/soc/sof/ipc4-loader.c @@ -40,6 +40,17 @@ static size_t sof_ipc4_fw_parse_ext_man(struct snd_sof_dev *sdev) ext_man_hdr = (struct sof_ext_manifest4_hdr *)fw->data; + /* + * At the start of the firmware image we must have an extended manifest. + * Verify that the magic number is correct. + */ + if (ext_man_hdr->id != SOF_EXT_MAN4_MAGIC_NUMBER) { + dev_err(sdev->dev, + "Unexpected extended manifest magic number: %#x\n", + ext_man_hdr->id); + return -EINVAL; + } + fw_hdr_offset = ipc4_data->manifest_fw_hdr_offset; if (!fw_hdr_offset) return -EINVAL; |