summaryrefslogtreecommitdiffstats
path: root/sound/usb/quirks.h
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2022-09-04 18:12:47 +0200
committerTakashi Iwai <tiwai@suse.de>2022-09-06 11:04:56 +0200
commit6392dcd1d0c7034ccf630ec55fc9e5810ecadf3b (patch)
tree1a2fcdd000bce3797068d53e21adf786d3934bef /sound/usb/quirks.h
parent16c5cde20e304cd900371b140cd53ecafe8d3de5 (diff)
downloadlinux-stable-6392dcd1d0c7034ccf630ec55fc9e5810ecadf3b.tar.gz
linux-stable-6392dcd1d0c7034ccf630ec55fc9e5810ecadf3b.tar.bz2
linux-stable-6392dcd1d0c7034ccf630ec55fc9e5810ecadf3b.zip
ALSA: usb-audio: Register card at the last interface
The USB-audio driver matches per interface, and as default, it registers the card instance at the very first instance. This can be a problem for the devices that have multiple interfaces to be probed, as the udev rule isn't applied properly for the later appearing interfaces. Although we introduced the delayed_register option and the quirks for covering those shortcomings, it's nothing but a workaround for specific devices. This patch is an another attempt to fix the problem in a more generic way. Now the driver checks the whole USB device descriptor at the very first time when an interface is attached to a sound card. It looks at each matching interface in the descriptor and remembers the last matching one. The snd_card_register() is invoked only when this last interface is probed. After this change, the quirks for the delayed registration become superfluous, hence they are removed along with the patch. OTOH, the delayed_register option is still kept, as it might be useful for some corner cases (e.g. a special driver overtakes the interface probe from the standard driver, and the last interface probe may miss). Link: https://lore.kernel.org/r/20220904161247.16461-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/quirks.h')
-rw-r--r--sound/usb/quirks.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/usb/quirks.h b/sound/usb/quirks.h
index 31abb7cb01a5..f9bfd5ac7bab 100644
--- a/sound/usb/quirks.h
+++ b/sound/usb/quirks.h
@@ -48,8 +48,6 @@ void snd_usb_audioformat_attributes_quirk(struct snd_usb_audio *chip,
struct audioformat *fp,
int stream);
-bool snd_usb_registration_quirk(struct snd_usb_audio *chip, int iface);
-
void snd_usb_init_quirk_flags(struct snd_usb_audio *chip);
#endif /* __USBAUDIO_QUIRKS_H */