diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-05-17 15:15:38 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-05-17 16:04:10 +0200 |
| commit | 4e268db74770b454b877ab5260f1868a457d212c (patch) | |
| tree | d739e23399bb1edb4774a6b005ceaab388f33ded /sound/usb/usx2y/usbusx2y.c | |
| parent | a829dd5b3840fd9a24608ed73eb21ba239ae5334 (diff) | |
| download | linux-stable-4e268db74770b454b877ab5260f1868a457d212c.tar.gz linux-stable-4e268db74770b454b877ab5260f1868a457d212c.tar.bz2 linux-stable-4e268db74770b454b877ab5260f1868a457d212c.zip | |
ALSA: usx2y: Fix potential leaks of uninitialized memory
usx2y drivers may expose the allocated pages via mmap, but it performs
zero-clear only for the struct size, not aligned with the page size.
This leaves out some uninitialized trailing bytes.
This patch fixes the clearance to cover all memory that are exposed to
user-space.
Link: https://lore.kernel.org/r/20210517131545.27252-5-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/usx2y/usbusx2y.c')
| -rw-r--r-- | sound/usb/usx2y/usbusx2y.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c index 05b10bdc6380..25e04a0ff97b 100644 --- a/sound/usb/usx2y/usbusx2y.c +++ b/sound/usb/usx2y/usbusx2y.c @@ -430,7 +430,7 @@ static void snd_usx2y_card_private_free(struct snd_card *card) usb_free_urb(usx2y->in04_urb); if (usx2y->us428ctls_sharedmem) free_pages_exact(usx2y->us428ctls_sharedmem, - sizeof(*usx2y->us428ctls_sharedmem)); + US428_SHAREDMEM_PAGES); if (usx2y->card_index >= 0 && usx2y->card_index < SNDRV_CARDS) snd_usx2y_card_used[usx2y->card_index] = 0; } |