diff options
| author | Cezary Rojewski <cezary.rojewski@intel.com> | 2022-12-05 09:53:29 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-12-07 14:19:04 +0000 |
| commit | 171107237246d66bce04f3769d33648f896b4ce3 (patch) | |
| tree | 2da544e99b1bd396ccc83d11d8f319a2421c329a /sound | |
| parent | 4ac587f3578c5ca490e4df55af6403f5474eb2f0 (diff) | |
| download | linux-stable-171107237246d66bce04f3769d33648f896b4ce3.tar.gz linux-stable-171107237246d66bce04f3769d33648f896b4ce3.tar.bz2 linux-stable-171107237246d66bce04f3769d33648f896b4ce3.zip | |
ASoC: Intel: Skylake: Fix driver hang during shutdown
AudioDSP cores and HDAudio links need to be turned off on shutdown to
ensure no communication or data transfer occurs during the procedure.
Fixes: c5a76a246989 ("ASoC: Intel: Skylake: Add shutdown callback")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Tested-by: Lukasz Majczak <lma@semihlaf.com>
Link: https://lore.kernel.org/r/20221205085330.857665-6-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/intel/skylake/skl.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 9bd9f9866898..998bd0232cf1 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -1107,7 +1107,10 @@ static void skl_shutdown(struct pci_dev *pci) if (!skl->init_done) return; - snd_hdac_stop_streams_and_chip(bus); + snd_hdac_stop_streams(bus); + snd_hdac_ext_bus_link_power_down_all(bus); + skl_dsp_sleep(skl->dsp); + list_for_each_entry(s, &bus->stream_list, list) { stream = stream_to_hdac_ext_stream(s); snd_hdac_ext_stream_decouple(bus, stream, false); |