summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-02-05 15:44:30 +0300
committerMark Brown <broonie@kernel.org>2024-02-05 14:31:35 +0000
commit4703b014f28bf7a2e56d1da238ee95ef6c5ce76b (patch)
tree2c5344ebfc14830a58a462f089ebb25e0c3839e1 /sound
parente81fdba0208666b65bafeaba814874b4d6e5edde (diff)
downloadlinux-stable-4703b014f28bf7a2e56d1da238ee95ef6c5ce76b.tar.gz
linux-stable-4703b014f28bf7a2e56d1da238ee95ef6c5ce76b.tar.bz2
linux-stable-4703b014f28bf7a2e56d1da238ee95ef6c5ce76b.zip
ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put()
It looks like the "!" character was added accidentally. The regmap_update_bits_check() function is normally going to succeed. This means the rest of the function is unreachable and we don't handle the situation where "changed" is true correctly. Fixes: 07f7d6e7a124 ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/codecs/cs35l56.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
index c23e29da4cfb..ebed5ab1245b 100644
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -115,7 +115,7 @@ static int cs35l56_dspwait_asp1tx_put(struct snd_kcontrol *kcontrol,
ret = regmap_update_bits_check(cs35l56->base.regmap, addr,
CS35L56_ASP_TXn_SRC_MASK, val, &changed);
- if (!ret)
+ if (ret)
return ret;
if (changed)