summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2024-03-15 11:14:42 +0100
committerTakashi Iwai <tiwai@suse.de>2024-03-15 11:16:47 +0100
commit587d67fd929ad89801bcc429675bda90d53f6592 (patch)
treef08d52a695fb2f89cf3aac5171ae8bad820b28d8 /sound
parent9b714a59b719b1ba9382c092f0f7aa4bbe94eba1 (diff)
downloadlinux-stable-587d67fd929ad89801bcc429675bda90d53f6592.tar.gz
linux-stable-587d67fd929ad89801bcc429675bda90d53f6592.tar.bz2
linux-stable-587d67fd929ad89801bcc429675bda90d53f6592.zip
ALSA: timer: Fix missing irq-disable at closing
The conversion to guard macro dropped the irq-disablement at closing mistakenly, which may lead to a race. Fix it. Fixes: beb45974dd49 ("ALSA: timer: Use guard() for locking") Reported-by: syzbot+28c1a5a5b041a754b947@syzkaller.appspotmail.com Closes: http://lore.kernel.org/r/0000000000000b9a510613b0145f@google.com Message-ID: <20240315101447.18395-1-tiwai@suse.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/core/timer.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 15b07d09c4b7..4d2ee99c12a3 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -409,7 +409,7 @@ static void snd_timer_close_locked(struct snd_timer_instance *timeri,
struct snd_timer *timer = timeri->timer;
if (timer) {
- guard(spinlock)(&timer->lock);
+ guard(spinlock_irq)(&timer->lock);
timeri->flags |= SNDRV_TIMER_IFLG_DEAD;
}