summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2022-02-07 08:09:23 -0800
committerMark Brown <broonie@kernel.org>2022-02-08 13:37:39 +0000
commit946eb87114af37c9c13c618a7c1cdaca936905fa (patch)
treea77d2346fe9fb788675abb00b2467349f20d26fd /sound
parent618c2dc667c87995cdc7de339224bd96bb049a1f (diff)
downloadlinux-stable-946eb87114af37c9c13c618a7c1cdaca936905fa.tar.gz
linux-stable-946eb87114af37c9c13c618a7c1cdaca936905fa.tar.bz2
linux-stable-946eb87114af37c9c13c618a7c1cdaca936905fa.zip
ASoC: Revert "ASoC: mediatek: Check for error clk pointer"
This reverts commit 9de2b9286a6d ("ASoC: mediatek: Check for error clk pointer"). With this patch in the tree, Chromebooks running the affected hardware no longer boot. Bisect points to this patch, and reverting it fixes the problem. An analysis of the code with this patch applied shows: ret = init_clks(pdev, clk); if (ret) return ERR_PTR(ret); ... for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { struct clk *c = clk[data->clk_id[j]]; if (IS_ERR(c)) { dev_err(&pdev->dev, "%s: clk unavailable\n", data->name); return ERR_CAST(c); } scpd->clk[j] = c; } Not all clocks in the clk_names array have to be present. Only the clocks in the data->clk_id array are actually needed. The code already checks if the required clocks are available and bails out if not. The assumption that all clocks have to be present is wrong, and commit 9de2b9286a6d ("ASoC: mediatek: Check for error clk pointer") needs to be reverted. Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn> Cc: Mark Brown <broonie@kernel.org> Cc: James Liao <jamesjj.liao@mediatek.com> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Reported-by: Frank Wunderlich <frank-w@public-files.de> Reported-by: Daniel Golle <daniel@makrotopia.org> Fixes: 9de2b9286a6d ("ASoC: mediatek: Check for error clk pointer") Signed-off-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20220207160923.3911501-1-linux@roeck-us.net Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
0 files changed, 0 insertions, 0 deletions