diff options
author | Bart Van Assche <bvanassche@acm.org> | 2024-03-04 15:57:15 -0800 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2024-03-05 10:40:58 +0100 |
commit | 961ebd120565cb60cebe21cb634fbc456022db4a (patch) | |
tree | 32f131221c73c86159b4be89dcc022f45ebf369b /sound | |
parent | 28468cbed92ea5eed19e2cbd2d55758c3c7938ca (diff) | |
download | linux-stable-961ebd120565cb60cebe21cb634fbc456022db4a.tar.gz linux-stable-961ebd120565cb60cebe21cb634fbc456022db4a.tar.bz2 linux-stable-961ebd120565cb60cebe21cb634fbc456022db4a.zip |
fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion
The first kiocb_set_cancel_fn() argument may point at a struct kiocb
that is not embedded inside struct aio_kiocb. With the current code,
depending on the compiler, the req->ki_ctx read happens either before
the IOCB_AIO_RW test or after that test. Move the req->ki_ctx read such
that it is guaranteed that the IOCB_AIO_RW test happens first.
Reported-by: Eric Biggers <ebiggers@kernel.org>
Cc: Benjamin LaHaise <ben@communityfibre.ca>
Cc: Eric Biggers <ebiggers@google.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Avi Kivity <avi@scylladb.com>
Cc: Sandeep Dhavale <dhavale@google.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: stable@vger.kernel.org
Fixes: b820de741ae4 ("fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240304235715.3790858-1-bvanassche@acm.org
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'sound')
0 files changed, 0 insertions, 0 deletions