summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2019-07-23 15:13:37 +0200
committerDaniel Vetter <daniel.vetter@ffwll.ch>2019-09-03 17:16:53 +0200
commitbd7e3f3ba1efab5c2c188d097589b9bc93ffaeaa (patch)
tree7a5908b42fbd254473dab7bb7a1ee8aaeabd3431 /sound
parent5fcd055193c5d4cac6d205bd65e52c957ea057c2 (diff)
downloadlinux-stable-bd7e3f3ba1efab5c2c188d097589b9bc93ffaeaa.tar.gz
linux-stable-bd7e3f3ba1efab5c2c188d097589b9bc93ffaeaa.tar.bz2
linux-stable-bd7e3f3ba1efab5c2c188d097589b9bc93ffaeaa.zip
drm/vblank: Document and fix vblank count barrier semantics
Noticed while reviewing code. I'm not sure whether this might or might not explain some of the missed vblank hilarity we've been seeing on various drivers (but those got tracked down to driver issues, at least mostly). I think those all go through the vblank completion event, which has unconditional barriers - it always takes the spinlock. Therefore no cc stable. v2: - Barrriers are hard, put them in in the right order (Chris). - Improve the comments a bit. v3: Ville noticed that on 32bit we might be breaking up the load/stores, now that the vblank counter has been switched over to be 64 bit. Fix that up by switching to atomic64_t. This this happens so rarely in practice I figured no need to cc: stable ... Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Keith Packard <keithp@keithp.com> References: 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190723131337.22031-1-daniel.vetter@ffwll.ch
Diffstat (limited to 'sound')
0 files changed, 0 insertions, 0 deletions