diff options
| author | Philipp Klocke <philipp97kl@gmail.com> | 2018-10-18 12:33:02 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-01 09:13:39 +0100 |
| commit | e7d723976099baad7eb092ded45ca5dbf3105a10 (patch) | |
| tree | c1c1bf7992af37fe8ec2e3c1a66087064fb71ad2 /sound | |
| parent | 7d704466f6533232e7ab2cfa37119f4b281f5439 (diff) | |
| download | linux-stable-e7d723976099baad7eb092ded45ca5dbf3105a10.tar.gz linux-stable-e7d723976099baad7eb092ded45ca5dbf3105a10.tar.bz2 linux-stable-e7d723976099baad7eb092ded45ca5dbf3105a10.zip | |
ALSA: i2c/cs8427: Fix int to char conversion
[ Upstream commit eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 ]
Compiling with clang yields the following warning:
sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int'
to 'char' changes value from 160 to -96 [-Wconstant-conversion]
data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF;
~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
Because CS8427_REG_AUTOINC is defined as 128, it is too big for a
char field.
So change data from char to unsigned char, that it can hold the value.
This patch does not change the generated code.
Signed-off-by: Philipp Klocke <philipp97kl@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/i2c/cs8427.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c index 7e21621e492a..7fd1b4000883 100644 --- a/sound/i2c/cs8427.c +++ b/sound/i2c/cs8427.c @@ -118,7 +118,7 @@ static int snd_cs8427_send_corudata(struct snd_i2c_device *device, struct cs8427 *chip = device->private_data; char *hw_data = udata ? chip->playback.hw_udata : chip->playback.hw_status; - char data[32]; + unsigned char data[32]; int err, idx; if (!memcmp(hw_data, ndata, count)) |