diff options
| author | He Kuang <hekuang@huawei.com> | 2019-01-21 00:05:22 +0800 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-01-21 11:29:07 -0300 |
| commit | da06d568386877809532e8ec678f4a5e300f0951 (patch) | |
| tree | aca3dd3b896c3881040bb1adfada5812f32cdb4f /tools/perf/builtin-script.c | |
| parent | 1497e804d1a6e2bd9107ddf64b0310449f4673eb (diff) | |
| download | linux-stable-da06d568386877809532e8ec678f4a5e300f0951.tar.gz linux-stable-da06d568386877809532e8ec678f4a5e300f0951.tar.bz2 linux-stable-da06d568386877809532e8ec678f4a5e300f0951.zip | |
perf top: Fix wrong hottest instruction highlighted
The annotation line percentage is compared and inserted into the rbtree,
but the percent field of 'struct annotation_data' is an array, the
comparison result between them is the address difference.
This patch compares the right slot of percent array according to
opts->percent_type and makes things right.
The problem can be reproduced by pressing 'H' in perf top annotation view.
It should highlight the instruction line which has the highest sampling
percentage.
Signed-off-by: He Kuang <hekuang@huawei.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20190120160523.4391-1-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-script.c')
0 files changed, 0 insertions, 0 deletions