summaryrefslogtreecommitdiffstats
path: root/tools/perf/pmu-events/arch
diff options
context:
space:
mode:
authorRob Herring <robh@kernel.org>2021-04-14 14:57:58 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2021-04-20 08:11:33 -0300
commit818869489ba3c4a4ed1360e22b2f66be488ea9f5 (patch)
tree6fc70f9cdaa9efb3640caa03f2752962ef865c6f /tools/perf/pmu-events/arch
parent47d01e7b9999b9591077a59a1ecec11c6ce570de (diff)
downloadlinux-stable-818869489ba3c4a4ed1360e22b2f66be488ea9f5.tar.gz
linux-stable-818869489ba3c4a4ed1360e22b2f66be488ea9f5.tar.bz2
linux-stable-818869489ba3c4a4ed1360e22b2f66be488ea9f5.zip
libperf xyarray: Add bounds checks to xyarray__entry()
xyarray__entry() is missing any bounds checking yet often the x and y parameters come from external callers. Add bounds checks and an unchecked __xyarray__entry(). Committer notes: Make the 'x' and 'y' arguments to the new xyarray__entry() that does bounds check to be of type 'size_t', so that we cover also the case where 'x' and 'y' could be negative, which is needed anyway as having them as 'int' breaks the build with: /home/acme/git/perf/tools/lib/perf/include/internal/xyarray.h: In function ‘xyarray__entry’: /home/acme/git/perf/tools/lib/perf/include/internal/xyarray.h:28:8: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 28 | if (x >= xy->max_x || y >= xy->max_y) | ^~ /home/acme/git/perf/tools/lib/perf/include/internal/xyarray.h:28:26: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 28 | if (x >= xy->max_x || y >= xy->max_y) | ^~ cc1: all warnings being treated as errors Signed-off-by: Rob Herring <robh@kernel.org> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org> Suggested-by: Namhyung Kim <namhyung@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lore.kernel.org/lkml/20210414195758.4078803-1-robh@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/pmu-events/arch')
0 files changed, 0 insertions, 0 deletions