diff options
| author | James Clark <james.clark@linaro.org> | 2024-11-29 15:19:48 +0000 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2024-12-02 12:36:35 -0800 |
| commit | f54cd8f43f55c0274c5b51509aff39675639c2e1 (patch) | |
| tree | 66be20ebbb295298950d9277bf7a143f15d63281 /tools/perf | |
| parent | 23c44f6c83257923b179461694edcf62749bedd5 (diff) | |
| download | linux-stable-f54cd8f43f55c0274c5b51509aff39675639c2e1.tar.gz linux-stable-f54cd8f43f55c0274c5b51509aff39675639c2e1.tar.bz2 linux-stable-f54cd8f43f55c0274c5b51509aff39675639c2e1.zip | |
perf test: Don't signal all processes on system when interrupting tests
This signal handler loops over all tests on ctrl-C, but it's active
while the test list is being constructed. process.pid is 0, then -1,
then finally set to the child pid on fork. If the Ctrl-C is received
during this point a kill(-1, SIGINT) can be sent which affects all
processes.
Make sure the child has forked first before forwarding the signal. This
can be reproduced with ctrl-C immediately after launching perf test
which terminates the ssh connection.
Fixes: 553d5efeb341 ("perf test: Add a signal handler to kill forked child processes")
Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241129151948.3199732-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/tests/builtin-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index 8dcf74d3c0a3..4751dd3c6f67 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -508,7 +508,7 @@ static int __cmd_test(struct test_suite **suites, int argc, const char *argv[], for (size_t x = 0; x < num_tests; x++) { struct child_test *child_test = child_tests[x]; - if (!child_test) + if (!child_test || child_test->process.pid <= 0) continue; pr_debug3("Killing %d pid %d\n", |