diff options
| author | Aaron Conole <aconole@redhat.com> | 2023-10-11 15:49:36 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-10-15 20:02:51 +0100 |
| commit | 92e37f20f20a23fec4626ae72eda50f127acb130 (patch) | |
| tree | dd04a451dc54a66d440168fb28a6905bbc0f3aa2 /tools/testing/selftests/net/openvswitch/openvswitch.sh | |
| parent | fc8b2a619469378717e7270d2a4e1ef93c585f7a (diff) | |
| download | linux-stable-92e37f20f20a23fec4626ae72eda50f127acb130.tar.gz linux-stable-92e37f20f20a23fec4626ae72eda50f127acb130.tar.bz2 linux-stable-92e37f20f20a23fec4626ae72eda50f127acb130.zip | |
selftests: openvswitch: Add version check for pyroute2
Paolo Abeni reports that on some systems the pyroute2 version isn't
new enough to run the test suite. Ensure that we support a minimum
version of 0.6 for all cases (which does include the existing ones).
The 0.6.1 version was released in May of 2021, so should be
propagated to most installations at this point.
The alternative that Paolo proposed was to only skip when the
add-flow is being run. This would be okay for most cases, except
if a future test case is added that needs to do flow dump without
an associated add (just guessing). In that case, it could also be
broken and we would need additional skip logic anyway. Just draw
a line in the sand now.
Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Closes: https://lore.kernel.org/lkml/8470c431e0930d2ea204a9363a60937289b7fdbe.camel@redhat.com/
Signed-off-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/net/openvswitch/openvswitch.sh')
| -rwxr-xr-x | tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh index 9c2012d70b08..220c3356901e 100755 --- a/tools/testing/selftests/net/openvswitch/openvswitch.sh +++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh @@ -525,7 +525,7 @@ run_test() { fi if python3 ovs-dpctl.py -h 2>&1 | \ - grep "Need to install the python" >/dev/null 2>&1; then + grep -E "Need to (install|upgrade) the python" >/dev/null 2>&1; then stdbuf -o0 printf "TEST: %-60s [PYLIB]\n" "${tdesc}" return $ksft_skip fi |