summaryrefslogtreecommitdiffstats
path: root/tools/testing
diff options
context:
space:
mode:
authorOndrej Mosnacek <omosnace@redhat.com>2020-04-14 16:23:51 +0200
committerPaul Moore <paul@paul-moore.com>2020-04-15 17:23:16 -0400
commitaf15f14c8cfcee515f4e9078889045ad63efefe3 (patch)
tree1b200b5d57bc5479434ac08daa0b15027d23f06a /tools/testing
parentc753924b628551564b6eea3c9896e4a95aa25ed9 (diff)
downloadlinux-stable-af15f14c8cfcee515f4e9078889045ad63efefe3.tar.gz
linux-stable-af15f14c8cfcee515f4e9078889045ad63efefe3.tar.bz2
linux-stable-af15f14c8cfcee515f4e9078889045ad63efefe3.zip
selinux: free str on error in str_read()
In [see "Fixes:"] I missed the fact that str_read() may give back an allocated pointer even if it returns an error, causing a potential memory leak in filename_trans_read_one(). Fix this by making the function free the allocated string whenever it returns a non-zero value, which also makes its behavior more obvious and prevents repeating the same mistake in the future. Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> Addresses-Coverity-ID: 1461665 ("Resource leaks") Fixes: c3a276111ea2 ("selinux: optimize storage of filename transitions") Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions