diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2024-05-07 00:04:06 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2024-05-07 12:44:02 -0300 |
| commit | b78854e5c008b01265d78c181332a3bb66c0abdf (patch) | |
| tree | aff43b6d95b20c890963d8fd5778ab988bdeefd5 /tools | |
| parent | ee73fe99f77b066afc5035727130a6b8016e64b6 (diff) | |
| download | linux-stable-b78854e5c008b01265d78c181332a3bb66c0abdf.tar.gz linux-stable-b78854e5c008b01265d78c181332a3bb66c0abdf.tar.bz2 linux-stable-b78854e5c008b01265d78c181332a3bb66c0abdf.zip | |
perf probe: Use zfree() to avoid possibly accessing dangling pointers
When freeing a->b it is good practice to set a->b to NULL using
zfree(&a->b) so that when we have a bug where a reference to a freed 'a'
pointer is kept somewhere, we can more quickly cause a segfault if some
code tries to use a->b.
Convert one such case in the 'perf probe' codebase.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/ZjpBnkL2wO3QJa5W@x1
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/builtin-probe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index 019fef8da6a8..003a3bcebfdf 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c @@ -325,7 +325,7 @@ static void cleanup_params(void) for (i = 0; i < params->nevents; i++) clear_perf_probe_event(params->events + i); line_range__clear(¶ms->line_range); - free(params->target); + zfree(¶ms->target); strfilter__delete(params->filter); nsinfo__put(params->nsi); zfree(¶ms); |