diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-12-14 18:01:02 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-16 10:21:37 +0000 |
| commit | d1c4a3469e73730f7cbbcec661c2a9081af1aa45 (patch) | |
| tree | 3987b96d23f5c8009a365b12b6b81dfc0be20f23 /tools | |
| parent | 2fc60e2ff972d3dca836bff0b08cbe503c4ca1ce (diff) | |
| download | linux-stable-d1c4a3469e73730f7cbbcec661c2a9081af1aa45.tar.gz linux-stable-d1c4a3469e73730f7cbbcec661c2a9081af1aa45.tar.bz2 linux-stable-d1c4a3469e73730f7cbbcec661c2a9081af1aa45.zip | |
selftests: devlink: add a warning for interfaces coming up
NetworkManager (and other daemons) may bring the interface up
and cause failures in quiescence checks. Print a helpful warning,
and take the interface down again.
I seem to forget about this every time I run these tests on a new VM.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh index 109900c817be..b64d98ca0df7 100755 --- a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh @@ -47,6 +47,17 @@ if [ -d "${NETDEVSIM_PATH}/devices/netdevsim${DEV_ADDR}" ]; then exit 1 fi +check_netdev_down() +{ + state=$(cat /sys/class/net/${NETDEV}/flags) + + if [ $((state & 1)) -ne 0 ]; then + echo "WARNING: unexpected interface UP, disable NetworkManager?" + + ip link set dev $NETDEV down + fi +} + init_test() { RET=0 @@ -151,6 +162,7 @@ trap_stats_test() RET=0 + check_netdev_down for trap_name in $(devlink_traps_get); do devlink_trap_stats_idle_test $trap_name check_err $? "Stats of trap $trap_name not idle when netdev down" @@ -254,6 +266,7 @@ trap_group_stats_test() RET=0 + check_netdev_down for group_name in $(devlink_trap_groups_get); do devlink_trap_group_stats_idle_test $group_name check_err $? "Stats of trap group $group_name not idle when netdev down" |