diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-09-30 15:06:01 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-06 13:05:43 +0100 |
| commit | ec783e28e72ddd09a139a54e66a6d32f9c231b9d (patch) | |
| tree | 49d4f3b596fd128f1b10e9209ec19df98cc0e282 /tools | |
| parent | f0ba7ab26bfc3b7c651a264ab283895a575b1cf7 (diff) | |
| download | linux-stable-ec783e28e72ddd09a139a54e66a6d32f9c231b9d.tar.gz linux-stable-ec783e28e72ddd09a139a54e66a6d32f9c231b9d.tar.bz2 linux-stable-ec783e28e72ddd09a139a54e66a6d32f9c231b9d.zip | |
perf annotate: Propagate perf_env__arch() error
[ Upstream commit a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b ]
The callers of symbol__annotate2() use symbol__strerror_disassemble() to
convert its failure returns into a human readable string, so
propagate error values from functions it calls, starting with
perf_env__arch() that when fails the right thing to do is to look at
'errno' to see why its possible call to uname() failed.
Reported-by: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/n/tip-it5d83kyusfhb1q1b0l4pxzs@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/annotate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index daea1fdf7385..4ef62bcdc80f 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -1871,7 +1871,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, int err; if (!arch_name) - return -1; + return errno; args.arch = arch = arch__find(arch_name); if (arch == NULL) |