diff options
| author | Marc Zyngier <maz@kernel.org> | 2020-04-06 16:21:20 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2020-04-22 17:13:16 +0100 |
| commit | 9a50ebbffa9862db7604345f5fd763122b0f6fed (patch) | |
| tree | 9b17d206d5214da49e312fcdb325d9501429ef8c /virt/kvm/arm/vgic/vgic-mmio.h | |
| parent | 1c32ca5dc6d00012f0c964e5fdd7042fcc71efb1 (diff) | |
| download | linux-stable-9a50ebbffa9862db7604345f5fd763122b0f6fed.tar.gz linux-stable-9a50ebbffa9862db7604345f5fd763122b0f6fed.tar.bz2 linux-stable-9a50ebbffa9862db7604345f5fd763122b0f6fed.zip | |
KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER read
When a guest tries to read the active state of its interrupts,
we currently just return whatever state we have in memory. This
means that if such an interrupt lives in a List Register on another
CPU, we fail to obsertve the latest active state for this interrupt.
In order to remedy this, stop all the other vcpus so that they exit
and we can observe the most recent value for the state. This is
similar to what we are doing for the write side of the same
registers, and results in new MMIO handlers for userspace (which
do not need to stop the guest, as it is supposed to be stopped
already).
Reported-by: Julien Grall <julien@xen.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Diffstat (limited to 'virt/kvm/arm/vgic/vgic-mmio.h')
| -rw-r--r-- | virt/kvm/arm/vgic/vgic-mmio.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h index 5af2aefad435..30713a44e3fa 100644 --- a/virt/kvm/arm/vgic/vgic-mmio.h +++ b/virt/kvm/arm/vgic/vgic-mmio.h @@ -152,6 +152,9 @@ void vgic_mmio_write_cpending(struct kvm_vcpu *vcpu, unsigned long vgic_mmio_read_active(struct kvm_vcpu *vcpu, gpa_t addr, unsigned int len); +unsigned long vgic_uaccess_read_active(struct kvm_vcpu *vcpu, + gpa_t addr, unsigned int len); + void vgic_mmio_write_cactive(struct kvm_vcpu *vcpu, gpa_t addr, unsigned int len, unsigned long val); |