diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2020-01-29 18:41:30 -0700 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2020-01-31 11:07:43 +0100 |
commit | e093e53f4f70b126ff63bc422e5135e934e35a1b (patch) | |
tree | 67274f24d3cf56957496967411df7096bc0f35d0 /virt | |
parent | db5a10c172ed0d41aa4139ef9f1abd8128568267 (diff) | |
download | linux-stable-e093e53f4f70b126ff63bc422e5135e934e35a1b.tar.gz linux-stable-e093e53f4f70b126ff63bc422e5135e934e35a1b.tar.bz2 linux-stable-e093e53f4f70b126ff63bc422e5135e934e35a1b.zip |
power: avs: qcom-cpr: Avoid clang -Wsometimes-uninitialized in cpr_scale
Clang warns (trimmed for brevity):
../drivers/power/avs/qcom-cpr.c:570:13: warning: variable 'reg_mask' is
used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
../drivers/power/avs/qcom-cpr.c:520:13: warning: variable 'new_uV' is
used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
Due to the fact that Clang's static analysis happens before any
optimization passes are taken into account, it cannot see that both
branches in the if statement must be taken because dir cannot be
something other than UP or DOWN due to the check at the top of this
function. Change the else if condition to else to fix this false
positive.
Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
Link: https://github.com/ClangBuiltLinux/linux/issues/840
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions