summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/display/skl_watermark.c
diff options
context:
space:
mode:
authorJani Nikula <jani.nikula@intel.com>2022-09-12 14:45:14 +0300
committerJani Nikula <jani.nikula@intel.com>2022-09-13 19:55:05 +0300
commit62a21a7c6a1cb7030eab8d64427d93b97cdeedec (patch)
tree9d96a265cc0ba270e0f53f33deffe7ba875d9d1f /drivers/gpu/drm/i915/display/skl_watermark.c
parentdde01ed5b07808be13d4469f90e578ff83774c25 (diff)
downloadlinux-62a21a7c6a1cb7030eab8d64427d93b97cdeedec.tar.gz
linux-62a21a7c6a1cb7030eab8d64427d93b97cdeedec.tar.bz2
linux-62a21a7c6a1cb7030eab8d64427d93b97cdeedec.zip
drm/i915/ipc: register debugfs only if IPC available
It looks like trying to enable IPC via debugfs on platforms that don't have IPC resulted in dmesg info message about IPC being enabled, which is clearly not possible and would not happen. Seems sensible to register IPC debugfs only on platforms that have IPC. Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/b18edb4f96c9d2ec728ef04e6f99d161fe5641d1.1662983005.git.jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/display/skl_watermark.c')
-rw-r--r--drivers/gpu/drm/i915/display/skl_watermark.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index a75599b49c80..c67497b5908f 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -3485,9 +3485,6 @@ static int skl_watermark_ipc_status_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- if (!HAS_IPC(i915))
- return -ENODEV;
-
return single_open(file, skl_watermark_ipc_status_show, i915);
}
@@ -3529,6 +3526,9 @@ void skl_watermark_ipc_debugfs_register(struct drm_i915_private *i915)
{
struct drm_minor *minor = i915->drm.primary;
+ if (!HAS_IPC(i915))
+ return;
+
debugfs_create_file("i915_ipc_status", 0644, minor->debugfs_root, i915,
&skl_watermark_ipc_status_fops);
}