diff options
author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-10-24 01:29:19 +0800 |
---|---|---|
committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-10-25 20:14:49 +0800 |
commit | 9e47e6f90880e090cd81f585abd7a6c553fbce10 (patch) | |
tree | c280e390d282db4c41d64718b366c1c3e64dc9ba /BaseTools/Source/Python/GenFds/Region.py | |
parent | 0019375fbc89e4d7cfebe29e288b74731bd9f456 (diff) | |
download | edk2-9e47e6f90880e090cd81f585abd7a6c553fbce10.tar.gz edk2-9e47e6f90880e090cd81f585abd7a6c553fbce10.tar.bz2 edk2-9e47e6f90880e090cd81f585abd7a6c553fbce10.zip |
BaseTools/GenFds: cleanup GenFds
1) remove wildcard imports and use explicit imports
2) refactor to use shared variables from Common/DataType
3) rename to not shadow imports
4) don't assign a variable in a loop (just do final assignment)
5) remove spaces, parens, unused or commented out code, etc.
6) merge unnecessary parent classes into child
7) refactor to share DXE and PEI apriori GUIDs from one place
this includes changes to Build and EOT files
8) for PEP8, dont use __ for custom methods.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob C Feng <bob.c.feng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/GenFds/Region.py')
-rw-r--r-- | BaseTools/Source/Python/GenFds/Region.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/BaseTools/Source/Python/GenFds/Region.py b/BaseTools/Source/Python/GenFds/Region.py index 5242b74c9e..9aeaa45d45 100644 --- a/BaseTools/Source/Python/GenFds/Region.py +++ b/BaseTools/Source/Python/GenFds/Region.py @@ -20,7 +20,6 @@ from struct import * from .GenFdsGlobalVariable import GenFdsGlobalVariable
from io import BytesIO
import string
-from CommonDataClass.FdfClass import RegionClassObject
import Common.LongFilePathOs as os
from stat import *
from Common import EdkLogger
@@ -32,15 +31,20 @@ from Common.DataType import BINARY_FILE_TYPE_FV ## generate Region
#
#
-class Region(RegionClassObject):
+class Region(object):
## The constructor
#
# @param self The object pointer
#
def __init__(self):
- RegionClassObject.__init__(self)
-
+ self.Offset = None # The begin position of the Region
+ self.Size = None # The Size of the Region
+ self.PcdOffset = None
+ self.PcdSize = None
+ self.SetVarDict = {}
+ self.RegionType = None
+ self.RegionDataList = []
## PadBuffer()
#
|