MpInitLib: Move the Above1Mb vector allocation to MpInitLibInitialize

The AP vector consists of 2 parts:
1. the initial 16-bit code that should be under 1MB and page aligned.
2. the 32-bit/64-bit code that can be anywhere in the memory with any
   alignment.

The need of part #2 is because the memory under 1MB is temporary
"stolen" for use and will "give" back after all AP wake up. The range
of memory is not marked as code page in page table. CPU may trigger
exception as soon as NX is enabled.

The part #2 memory allocation can be done in the MpInitLibInitialize.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

1 files changed, 29 insertions, 24 deletions

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index a3e89495e1..8d1f24370a 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -955,18 +955,6 @@ FillExchangeInfoData (
     Size     -= sizeof (IA32_SEGMENT_DESCRIPTOR);

   }

 

-  //

-  // Copy all 32-bit code and 64-bit code into memory with type of

-  // EfiBootServicesCode to avoid page fault if NX memory protection is enabled.

-  //

-  GetApResetVectorSize (&CpuMpData->AddressMap, NULL, &Size);

-  CopyMem (

-    (VOID *)CpuMpData->WakeupBufferHigh,

-    CpuMpData->AddressMap.RendezvousFunnelAddress +

-    CpuMpData->AddressMap.ModeTransitionOffset,

-    Size

-    );

-

   ExchangeInfo->ModeTransitionMemory = (UINT32)CpuMpData->WakeupBufferHigh;

 

   ExchangeInfo->ModeHighMemory = ExchangeInfo->ModeTransitionMemory +

@@ -1035,21 +1023,24 @@ RestoreWakeupBuffer (
   @param[in, out]  CpuMpData  The pointer to CPU MP Data structure.

 **/

 VOID

-AllocateResetVector (

+AllocateResetVectorBelow1Mb (

   IN OUT CPU_MP_DATA  *CpuMpData

   )

 {

-  UINTN  ApResetVectorSizeBelow1Mb;

-  UINTN  ApResetVectorSizeAbove1Mb;

   UINTN  ApResetStackSize;

 

   if (CpuMpData->WakeupBuffer == (UINTN)-1) {

-    GetApResetVectorSize (&CpuMpData->AddressMap, &ApResetVectorSizeBelow1Mb, &ApResetVectorSizeAbove1Mb);

-

-    CpuMpData->WakeupBuffer      = GetWakeupBuffer (ApResetVectorSizeBelow1Mb);

+    CpuMpData->WakeupBuffer      = GetWakeupBuffer (CpuMpData->BackupBufferSize);

     CpuMpData->MpCpuExchangeInfo = (MP_CPU_EXCHANGE_INFO *)(UINTN)

-                                   (CpuMpData->WakeupBuffer + ApResetVectorSizeBelow1Mb - sizeof (MP_CPU_EXCHANGE_INFO));

-    CpuMpData->WakeupBufferHigh = AllocateCodeBuffer (ApResetVectorSizeAbove1Mb);

+                                   (CpuMpData->WakeupBuffer + CpuMpData->BackupBufferSize - sizeof (MP_CPU_EXCHANGE_INFO));

+    DEBUG ((

+      DEBUG_INFO,

+      "AP Vector: 16-bit = %p/%x, ExchangeInfo = %p/%x\n",

+      CpuMpData->WakeupBuffer,

+      CpuMpData->BackupBufferSize - sizeof (MP_CPU_EXCHANGE_INFO),

+      CpuMpData->MpCpuExchangeInfo,

+      sizeof (MP_CPU_EXCHANGE_INFO)

+      ));

     //

     // The AP reset stack is only used by SEV-ES guests. Do not allocate it

     // if SEV-ES is not enabled. An SEV-SNP guest is also considered

@@ -1148,7 +1139,7 @@ WakeUpAP (
       (CpuMpData->InitFlag   != ApInitDone))

   {

     ResetVectorRequired = TRUE;

-    AllocateResetVector (CpuMpData);

+    AllocateResetVectorBelow1Mb (CpuMpData);

     AllocateSevEsAPMemory (CpuMpData);

     FillExchangeInfoData (CpuMpData);

     SaveLocalApicTimerSetting (CpuMpData);

@@ -1789,6 +1780,7 @@ MpInitLibInitialize (
   UINT8                    *MonitorBuffer;

   UINTN                    Index;

   UINTN                    ApResetVectorSizeBelow1Mb;

+  UINTN                    ApResetVectorSizeAbove1Mb;

   UINTN                    BackupBufferAddr;

   UINTN                    ApIdtBase;

 

@@ -1802,9 +1794,9 @@ MpInitLibInitialize (
   ASSERT (MaxLogicalProcessorNumber != 0);

 

   AsmGetAddressMap (&AddressMap);

-  GetApResetVectorSize (&AddressMap, &ApResetVectorSizeBelow1Mb, NULL);

-  ApStackSize       = PcdGet32 (PcdCpuApStackSize);

-  ApLoopMode        = GetApLoopMode (&MonitorFilterSize);

+  GetApResetVectorSize (&AddressMap, &ApResetVectorSizeBelow1Mb, &ApResetVectorSizeAbove1Mb);

+  ApStackSize = PcdGet32 (PcdCpuApStackSize);

+  ApLoopMode  = GetApLoopMode (&MonitorFilterSize);

 

   //

   // Save BSP's Control registers for APs.

@@ -1914,6 +1906,19 @@ MpInitLibInitialize (
   }

 

   //

+  // Copy all 32-bit code and 64-bit code into memory with type of

+  // EfiBootServicesCode to avoid page fault if NX memory protection is enabled.

+  //

+  CpuMpData->WakeupBufferHigh = AllocateCodeBuffer (ApResetVectorSizeAbove1Mb);

+  CopyMem (

+    (VOID *)CpuMpData->WakeupBufferHigh,

+    CpuMpData->AddressMap.RendezvousFunnelAddress +

+    CpuMpData->AddressMap.ModeTransitionOffset,

+    ApResetVectorSizeAbove1Mb

+    );

+  DEBUG ((DEBUG_INFO, "AP Vector: non-16-bit = %p/%x\n", CpuMpData->WakeupBufferHigh, ApResetVectorSizeAbove1Mb));

+

+  //

   // Enable the local APIC for Virtual Wire Mode.

   //

   ProgramVirtualWireMode ();